Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12770023: Remove dubious assertion. (Closed)

Created:
7 years, 9 months ago by tfarina
Modified:
7 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove dubious assertion. Clang error report: ../../src/animator/SkDrawBitmap.cpp:89:21: error: comparison of constant 4294967295 with expression of type 'int' is always true [-Werror,-Wtautological-constant-out-of-range-compare] SkASSERT(format != (SkBitmap::Config) -1); ~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~ R=bsalomon@google.com,reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=8418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/animator/SkDrawBitmap.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Is this the right fix?
7 years, 9 months ago (2013-03-27 13:12:45 UTC) #1
tfarina
Would a better fix to compare |format| against kConfigCount? I guess that is what it's ...
7 years, 9 months ago (2013-03-27 13:15:19 UTC) #2
reed1
lgtm
7 years, 9 months ago (2013-03-27 14:13:06 UTC) #3
tfarina
7 years, 9 months ago (2013-03-27 21:24:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698