Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: trunk/src/chrome/common/extensions/features/simple_feature.h

Issue 12770020: Revert 190836 "Implement API features for the Extension API feat..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/features/simple_feature.h
===================================================================
--- trunk/src/chrome/common/extensions/features/simple_feature.h (revision 190861)
+++ trunk/src/chrome/common/extensions/features/simple_feature.h (working copy)
@@ -30,9 +30,8 @@
// Parses the JSON representation of a feature into the fields of this object.
// Unspecified values in the JSON are not modified in the object. This allows
- // us to implement inheritance by parsing one value after another. Returns
- // the error found, or an empty string on success.
- virtual std::string Parse(const DictionaryValue* value);
+ // us to implement inheritance by parsing one value after another.
+ void Parse(const DictionaryValue* value);
// Returns true if the feature contains the same values as another.
bool Equals(const SimpleFeature& other) const;

Powered by Google App Engine
This is Rietveld 408576698