Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: trunk/src/chrome/common/extensions/features/simple_feature.cc

Issue 12770020: Revert 190836 "Implement API features for the Extension API feat..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/features/simple_feature.cc
===================================================================
--- trunk/src/chrome/common/extensions/features/simple_feature.cc (revision 190861)
+++ trunk/src/chrome/common/extensions/features/simple_feature.cc (working copy)
@@ -208,10 +208,9 @@
channel_ == other.channel_;
}
-std::string SimpleFeature::Parse(const DictionaryValue* value) {
+void SimpleFeature::Parse(const DictionaryValue* value) {
ParseURLPatterns(value, "matches", &matches_);
ParseSet(value, "whitelist", &whitelist_);
- ParseSet(value, "dependencies", &dependencies_);
ParseEnumSet<Manifest::Type>(value, "extension_types", &extension_types_,
g_mappings.Get().extension_types);
ParseEnumSet<Context>(value, "contexts", &contexts_,
@@ -225,11 +224,6 @@
ParseEnum<VersionInfo::Channel>(
value, "channel", &channel_,
g_mappings.Get().channels);
- if (matches_.is_empty() && contexts_.count(WEB_PAGE_CONTEXT) != 0) {
- return name() + ": Allowing web_page contexts requires supplying a value " +
- "for matches.";
- }
- return "";
}
Feature::Availability SimpleFeature::IsAvailableToManifest(

Powered by Google App Engine
This is Rietveld 408576698