Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: trunk/src/chrome/common/extensions/features/feature.h

Issue 12770020: Revert 190836 "Implement API features for the Extension API feat..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/features/feature.h
===================================================================
--- trunk/src/chrome/common/extensions/features/feature.h (revision 190861)
+++ trunk/src/chrome/common/extensions/features/feature.h (working copy)
@@ -88,7 +88,6 @@
const std::string message_;
};
- Feature();
virtual ~Feature();
// Used by ChromeV8Context until the feature system is fully functional.
@@ -125,7 +124,6 @@
const std::string& name() const { return name_; }
void set_name(const std::string& name) { name_ = name; }
- const std::set<std::string>& dependencies() { return dependencies_; }
// Gets the platform the code is currently running on.
static Platform GetCurrentPlatform();
@@ -133,6 +131,7 @@
// Gets the Feature::Location value for the specified Manifest::Location.
static Location ConvertLocation(Manifest::Location extension_location);
+ // TODO(justinlin): Remove and move to APIFeature when it exists.
virtual std::set<Context>* GetContexts() = 0;
// Returns true if the feature is available to be parsed into a new extension
@@ -168,7 +167,6 @@
protected:
std::string name_;
- std::set<std::string> dependencies_;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698