Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12770020: Revert 190836 "Implement API features for the Extension API feat..." (Closed)

Created:
7 years, 9 months ago by eugenis
Modified:
7 years, 9 months ago
Reviewers:
cduvall
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 190836 "Implement API features for the Extension API feat..." Multiple leaks on the memory waterfall. BUG=224206 > Implement API features for the Extension API feature system > > Now features can be declared in the _api_features.json file, and dependencies > of the form "api:<api_name>" will refer to these features. > > This patch also prevents schemas for APIs using the feature system from being > loaded when calling ExtensionAPI::IsAvailable(). > > TBR=ben@chromium.org > BUG=55316, 120070 > > > Review URL: https://chromiumcodereview.appspot.com/12846011 TBR=cduvall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -390 lines) Patch
M trunk/src/chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/common_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -19 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/bookmarks.json View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/extension_api.h View 4 chunks +24 lines, -5 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/extension_api.cc View 9 chunks +114 lines, -38 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/extension_api_unittest.cc View 5 chunks +71 lines, -116 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/webstore.json View 1 chunk +11 lines, -0 lines 0 comments Download
D trunk/src/chrome/common/extensions/features/api_feature.h View 1 chunk +0 lines, -22 lines 0 comments Download
D trunk/src/chrome/common/extensions/features/api_feature.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/base_feature_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/base_feature_provider.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/base_feature_provider_unittest.cc View 5 chunks +3 lines, -9 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/feature.h View 4 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/feature.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/manifest_feature.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/manifest_feature.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/permission_feature.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/permission_feature.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/simple_feature.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/features/simple_feature.cc View 2 chunks +1 line, -7 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/extension_api_unittest/api_features.json View 1 chunk +0 lines, -54 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/extension_api_unittest/is_privileged_features_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/extension_api_unittest/is_privileged_features_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/extension_api_unittest/is_privileged_features_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/extension_api_unittest/is_privileged_features_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/extension_api_unittest/is_privileged_features_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/extension_api_unittest/privileged_api_features.json View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eugenis
7 years, 9 months ago (2013-03-27 08:24:36 UTC) #1
eugenis
Committed patchset #1 manually as r190862.
7 years, 9 months ago (2013-03-27 08:24:55 UTC) #2
cduvall
7 years, 9 months ago (2013-03-27 17:33:13 UTC) #3
Message was sent while issue was closed. 
Fixed the leak, attempting to commit again here:
https://codereview.chromium.org/12846011/

Powered by Google App Engine
This is Rietveld 408576698