Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/unittest/lib/html_layout_config.dart

Issue 12770017: pkg/unittest: config refactor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: per siggi's recomendations Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/lib/html_individual_config.dart ('k') | pkg/unittest/lib/interactive_html_config.dart » ('j') | pkg/unittest/test/unittest_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_layout_config.dart
diff --git a/pkg/unittest/lib/html_layout_config.dart b/pkg/unittest/lib/html_layout_config.dart
index ddb0415df75943fb398f2348a3eebb682d6f3da7..045a496ed40e14fb204ab9c39d81b1c26e065bab 100644
--- a/pkg/unittest/lib/html_layout_config.dart
+++ b/pkg/unittest/lib/html_layout_config.dart
@@ -306,12 +306,13 @@ void _prepareDom() {
* child, depending on whether the URL has a search part.
*/
void useHtmlLayoutConfiguration() {
- if (config != null) return;
if (window.location.search == '') { // This is the parent.
_prepareDom();
- configure(new ParentHtmlConfiguration());
+ config = _singletonParent;
} else {
- configure(new ChildHtmlConfiguration());
+ config = _singletonChild;
}
}
+final _singletonParent = new ParentHtmlConfiguration();
+final _singletonChild = new ChildHtmlConfiguration();
« no previous file with comments | « pkg/unittest/lib/html_individual_config.dart ('k') | pkg/unittest/lib/interactive_html_config.dart » ('j') | pkg/unittest/test/unittest_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698