pkg/unittest: config refactor

pkg/unittest/lib/unittest.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, install the
  * [unittest package](http://pub.dartlang.org/packages/unittest) via the pub
  * package manager. See the [Getting Started](http://pub.dartlang.org/doc)
@@ skipping 138 matching lines @@
  *         });
  *       });
  *     }
  *
  */
 library unittest;
 
 import 'dart:async';
 import 'dart:isolate';
 import 'matcher.dart';
+import 'package:meta/meta.dart';

[Siggi Cherem (dart-lang), 2013/03/24 17:20:09]

unfortunately this library is used within the dart-repo in a way that prevent's
us from using "package:" imports here. I believe you can work around this by
using:

  import '../../../pkg/meta/lib/meta.dart'

But note that it is not enough to use '../../meta/lib/meta.dart'. You need to
get all the way to 'pkg' so that the scripts that publish unittest as a package
can work.

I'm not sure if just fixing the import is enough, so I'm adding Andrei and Dan
to see if any of them can share any light. In particular, I recall trying to add
a deprecation warning in unittest before and it was painful to get it working
=(... I even gave up on it at some point, but can't recall why.

[Andrei Mouravski, 2013/03/24 18:49:23]

From what I remember, this wasn't working because dartdoc, and by extension,
apidoc, was breaking on trying to find the library itself. I'm pretty sure this
is actually fixed, but the the test is something like:
rm -rf out/ReleaseIA32/api_docs && build.py -m release
or equivalent on Mac/Win

 export 'matcher.dart';
 
 // TODO(amouravski): We should not need to import mock here, but it's necessary
 // to enable dartdoc on the mock library, as it's not picked up normally.
 import 'mock.dart';
 
 part 'src/config.dart';
 part 'src/test_case.dart';
 
+Configuration _config;
+
 /** [Configuration] used by the unittest library. */
-Configuration _config = null;
-
 Configuration get config => _config;
 
 /**
- * Set the [Configuration] used by the unittest library. Returns any
- * previous configuration.
- * TODO: consider deprecating in favor of a setter now we have a getter.
+ * Set the [Configuration] used by the unittest library.
+ *
+ * Throws an exception if a value has already been set.
  */
+void set config(Configuration value) {
+  if(_config != null) {
+    throw 'config has already been set';
+  }
+  _config = value;
+}
+
+/**
+ * Use [config] instead.
+ */
+@deprecated
 Configuration configure(Configuration config) {
   Configuration _oldConfig = _config;
   _config = config;
   return _oldConfig;
 }
 
 void logMessage(String message) => _config.logMessage(message);
 
 /**
  * Description text of the current test group. If multiple groups are nested,
@@ skipping 619 matching lines @@
   }
   _initialized = true;
   // Hook our async guard into the matcher library.
   wrapAsync = (f, [id]) => expectAsync1(f, id: id);
 
   _tests = <TestCase>[];
   _testRunner = _nextBatch;
   _uncaughtErrorMessage = null;
 
   if (_config == null) {
-    _config = new Configuration();
+    config = new Configuration();

[Siggi Cherem (dart-lang), 2013/03/24 17:20:09]

let's keep this with _config (you already checked for null anyways)

   }
   _config.onInit();
 
   if (_config.autoStart) {
     // Immediately queue the suite up. It will run after a timeout (i.e. after
     // main() has returned).
     _defer(runTests);
   }
 }
 
@@ skipping 23 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef dynamic TestFunction();