Port PerfWarm startup test to Telemetry

Port PerfWarm startup test to Telemetry

First step of porting tests in chrome/test/perf/startup_test.cc to Telemetry.  The motivation for this is to lower flakiness and make it easier to create startup tests using dirty profiles.

Note: The test measures the time it takes the browser to start spinning the main message loop so the exact URL used for the test is irrelevant.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189070

[nduca, 2013-03-12 18:47:41]

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
File tools/perf/page_sets/blank_25.json (right):

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
tools/perf/page_sets/blank_25.json:3: "pages": [
i think marja added a repeat option. Can we accomplish this with that?

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
tools/perf/page_sets/blank_25.json:5: "url":
"file:///blank_page/blank_page.html"
dont we have a page_sets/blank.html lying around? I dont think it needs to be in
its own directory...

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
File tools/perf/perf_tools/startup_tests.py (right):

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
tools/perf/perf_tools/startup_tests.py:7: # TODO(jeremy): Discard results from
first iteration of warm tests.
This sounds like something you want to add as a feature of the page_benchmark or
page_runner system... e.g. copy the style of
needs_browser_restart_after_each_run.

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
tools/perf/perf_tools/startup_tests.py:20:
'domAutomationController.getBrowserHistogram('
there's a file in perf_tools for accessing histograms cleanly, can you use that?

[jeremy, 2013-03-13 08:16:53]

All fixed, ready for another look, thanks!

Buildbot integration and skipping first iteration will come in a followup patch.

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
File tools/perf/page_sets/blank_25.json (right):

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
tools/perf/page_sets/blank_25.json:3: "pages": [
Yep, much better option - done.

https://codereview.chromium.org/12770005/diff/1/tools/perf/page_sets/blank_25...
tools/perf/page_sets/blank_25.json:5: "url":
"file:///blank_page/blank_page.html"
Done, If we have one already I haven't found it.

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
File tools/perf/perf_tools/startup_tests.py (right):

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
tools/perf/perf_tools/startup_tests.py:7: # TODO(jeremy): Discard results from
first iteration of warm tests.
Agreed, will do so in followup patch.

https://codereview.chromium.org/12770005/diff/1/tools/perf/perf_tools/startup...
tools/perf/perf_tools/startup_tests.py:20:
'domAutomationController.getBrowserHistogram('
The way i understand the code perf_tools/histogram_measurement is used to
subtract histograms and do all kinds of other fancy stuff.  I'd need to change
it to just get a plain histogram value here and I don't think we gain much but I
may very well be wrong.

[nduca, 2013-03-13 16:57:28]

lgtm with small nits.

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
File tools/perf/perf_tools/startup_tests.py (right):

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
tools/perf/perf_tools/startup_tests.py:19: result = tab.EvaluateJavaScript(
multiline quote would help here maybe

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
tools/perf/perf_tools/startup_tests.py:20:
'domAutomationController.getBrowserHistogram('
i think it'd be good to add the appropriate method to the histogram helper code.
Maybe just make a passthrough method--- get me this browser histogram raw.

[jeremy, 2013-03-19 14:38:05]

Thanks Nat, Committing - will fix Histogram remarks in a followup patch if
needed.

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
File tools/perf/perf_tools/startup_tests.py (right):

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
tools/perf/perf_tools/startup_tests.py:19: result = tab.EvaluateJavaScript(
On 2013/03/13 16:57:29, nduca wrote:
> multiline quote would help here maybe

Done.

https://codereview.chromium.org/12770005/diff/6001/tools/perf/perf_tools/star...
tools/perf/perf_tools/startup_tests.py:20:
'domAutomationController.getBrowserHistogram('
Not sure what you mean by a passthrough method.  Do you want me to expose
HistogramMeasurement._GetHistogramFromDomAutomation directly?

[commit-bot: I haz the power, 2013-03-19 14:38:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/12770005/11001

[commit-bot: I haz the power, 2013-03-19 19:52:53]

Change committed as 189070