Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1276993002: Revert of Add custom tabs tests using intents with non-null sessions (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
Theresa, newt (away)
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add custom tabs tests using intents with non-null sessions (patchset #3 id:40001 of https://codereview.chromium.org/1267243003/ ) Reason for revert: Test flaking on dowsntream ToT due to deferred startup not finishing. Original issue's description: > Add custom tabs tests using intents with non-null sessions > > All current tests either test the service side session creation without > launching intents or the UI customization with no sessions. This change > add a trivial test that uses a valid session to launch an intent and also > another more complex test that reloads a new URL in the same tab when the > same session is used inside the intent. > > Note that the service side is interfaced directly through CustomTabConnection > and this doesn't exactly replicate the actual scenario since all calls come > from the same process. > > Committed: https://crrev.com/a69c3f7ba69a30aef2143945b8b2bbf8e6421080 > Cr-Commit-Position: refs/heads/master@{#342131} TBR=newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/62bfb371d47b91bd0a328965af87e6f35ca95a42 Cr-Commit-Position: refs/heads/master@{#342169}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
Yusuf
Created Revert of Add custom tabs tests using intents with non-null sessions
5 years, 4 months ago (2015-08-06 19:04:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276993002/1
5 years, 4 months ago (2015-08-06 19:04:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 19:06:16 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 19:07:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62bfb371d47b91bd0a328965af87e6f35ca95a42
Cr-Commit-Position: refs/heads/master@{#342169}

Powered by Google App Engine
This is Rietveld 408576698