Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1276903003: Use vector image resources in extension install dialog. (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use vector image resources in extension install dialog. This also fixes this image for non-1x scale factors. This UI is visible for example when installing the "Rock Solid Scale Reader" app. BUG=505953 Committed: https://crrev.com/6e73a6cccf0b60a64d862cfb7763937c25fbcd73 Cr-Commit-Position: refs/heads/master@{#342679}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
D chrome/app/theme/default_100_percent/common/down_arrow.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/up_arrow.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 7 chunks +26 lines, -31 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
https://codereview.chromium.org/1276903003/diff/1/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (left): https://codereview.chromium.org/1276903003/diff/1/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc#oldcode534 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:534: icon->SetHorizontalAlignment(views::ImageView::CENTER); unrelated, but these are already the defaults https://codereview.chromium.org/1276903003/diff/1/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc#oldcode735 ...
5 years, 4 months ago (2015-08-10 17:13:40 UTC) #2
sky
LGTM
5 years, 4 months ago (2015-08-10 19:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276903003/1
5 years, 4 months ago (2015-08-10 20:05:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 20:11:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 20:12:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e73a6cccf0b60a64d862cfb7763937c25fbcd73
Cr-Commit-Position: refs/heads/master@{#342679}

Powered by Google App Engine
This is Rietveld 408576698