tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart - Issue 1276843008: dart2js cps: Change rewriting of equality operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart

Issue 1276843008: dart2js cps: Change rewriting of equality operators. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update test + minor improvement in logical rewriter Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart

diff --git a/tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart b/tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart

index 138e68446547196ae53442b8289a4d0b59c5a1dc..534db6334865eb6cf039eb6d6f1009ba81218c35 100644

--- a/tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart

+++ b/tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart

@@ -40,14 +40,14 @@ get foo => foo;

main() { print(foo && foo); }

""", """

function() {

- P.print(V.foo() ? !!P.identical(V.foo(), true) : false);

+ P.print(V.foo() ? V.foo() === true : false);

}"""),

const TestEntry("""

get foo => foo;

main() { print(foo || foo); }

""","""

function() {

- P.print(V.foo() ? true : !!P.identical(V.foo(), true));

+ P.print(V.foo() ? true : V.foo() === true);

}"""),

// Needs interceptor calling convention