Issue 1276843004: Helpful checks.cc file is being helpful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276843004: Helpful checks.cc file is being helpful. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Helpful checks.cc file is being helpful. R=titzer@chromium.org Committed: https://crrev.com/325257744f795f8611fd79778a952fdf69b5db64 Cr-Commit-Position: refs/heads/master@{#30046}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -11 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/checks.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

titzer

On 2015/08/06 12:56:06, Michael Starzinger wrote: LGTM. I guess this is where CheckEqualsHelper used to ...

5 years, 4 months ago (2015-08-06 12:58:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276843004/1

5 years, 4 months ago (2015-08-06 13:13:36 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-06 13:33:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/325257744f795f8611fd79778a952fdf69b5db64
Cr-Commit-Position: refs/heads/master@{#30046}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages