Chromium Code Reviews

Issue 1276843004: Helpful checks.cc file is being helpful. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Helpful checks.cc file is being helpful. R=titzer@chromium.org Committed: https://crrev.com/325257744f795f8611fd79778a952fdf69b5db64 Cr-Commit-Position: refs/heads/master@{#30046}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -11 lines)
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
D src/checks.cc View 1 chunk +0 lines, -9 lines 0 comments
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-06 12:56:06 UTC) #1
titzer
On 2015/08/06 12:56:06, Michael Starzinger wrote: LGTM. I guess this is where CheckEqualsHelper used to ...
5 years, 4 months ago (2015-08-06 12:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276843004/1
5 years, 4 months ago (2015-08-06 13:13:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 13:33:41 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 13:33:59 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/325257744f795f8611fd79778a952fdf69b5db64
Cr-Commit-Position: refs/heads/master@{#30046}

Powered by Google App Engine