Issue 127683002: Less dependency for DriveAppRegistry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127683002: Less dependency for DriveAppRegistry. (Closed)

Created:
6 years, 11 months ago by kinaba

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Less dependency for DriveAppRegistry. - It now directly accesses DriveServiceInterface instead of JobScheduler so that the class can be used outside chromeos/. - Use of ScopedVector is replaced by std::vector. BUG=332014, 312566 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243662

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -64 lines)			Patch
M	chrome/browser/chromeos/drive/drive_app_registry.h	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_app_registry.cc	View	6 chunks	+11 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_app_registry_unittest.cc	View	4 chunks	+19 lines, -32 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/file_tasks.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/127683002/1

6 years, 11 months ago (2014-01-08 16:23:42 UTC) #3

Message was sent while issue was closed.

Change committed as 243662

Expand Messages | Collapse Messages