Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 1276763002: Avoid UAF in PepperUDP/TCPSocketMessageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
index 36482d098f51d08135c074d68b6bab5d31ae3382..547483121a5943f38aa5fd10661958804ab08f12 100644
--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
@@ -76,7 +76,9 @@ PepperUDPSocketMessageFilter::PepperUDPSocketMessageFilter(
external_plugin_(host->external_plugin()),
private_api_(private_api),
render_process_id_(0),
- render_frame_id_(0) {
+ render_frame_id_(0),
+ is_potentially_secure_plugin_context_(
+ host->IsPotentiallySecurePluginContext(instance)) {
++g_num_instances;
DCHECK(host);
@@ -690,9 +692,8 @@ void PepperUDPSocketMessageFilter::SendBindReply(
const ppapi::host::ReplyMessageContext& context,
int32_t result,
const PP_NetAddress_Private& addr) {
- UMA_HISTOGRAM_BOOLEAN(
- "Pepper.PluginContextSecurity.UDPBind",
- host_->IsPotentiallySecurePluginContext(resource_host()->pp_instance()));
+ UMA_HISTOGRAM_BOOLEAN("Pepper.PluginContextSecurity.UDPBind",
+ is_potentially_secure_plugin_context_);
ppapi::host::ReplyMessageContext reply_context(context);
reply_context.params.set_result(result);
« no previous file with comments | « content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698