runtime/vm/thread_interrupter_linux.cc - Issue 1276753003: Correct thread state update order (fixes Windows crashes).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_interrupter_linux.cc

Issue 1276753003: Correct thread state update order (fixes Windows crashes). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Mac, Android. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_interrupter_linux.cc

diff --git a/runtime/vm/thread_interrupter_linux.cc b/runtime/vm/thread_interrupter_linux.cc

index 5ff3c92f5cc324563188592425fcf71a3ab55ef9..5b275c237bbd41509ecca03c72f9fd82f352ad0a 100644

--- a/runtime/vm/thread_interrupter_linux.cc

+++ b/runtime/vm/thread_interrupter_linux.cc

@@ -48,7 +48,8 @@ void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) {

OS::Print("ThreadInterrupter interrupting %p\n",

reinterpret_cast<void*>(state->id));

}

- pthread_kill(state->id, SIGPROF);

+ int result = pthread_kill(state->id, SIGPROF);

+ ASSERT(result == 0);

}

« no previous file with comments | « runtime/vm/thread_interrupter_android.cc ('k') | runtime/vm/thread_interrupter_macos.cc » ('j') | no next file with comments »