Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: runtime/vm/thread_interrupter_macos.cc

Issue 1276753003: Correct thread state update order (fixes Windows crashes). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Mac, Android. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include "vm/flags.h" 8 #include "vm/flags.h"
9 #include "vm/os.h" 9 #include "vm/os.h"
10 #include "vm/signal_handler.h" 10 #include "vm/signal_handler.h"
(...skipping 29 matching lines...) Expand all
40 its.lr = SignalHandler::GetLinkRegister(mcontext); 40 its.lr = SignalHandler::GetLinkRegister(mcontext);
41 state->callback(its, state->data); 41 state->callback(its, state->data);
42 } 42 }
43 }; 43 };
44 44
45 45
46 void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) { 46 void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) {
47 if (FLAG_trace_thread_interrupter) { 47 if (FLAG_trace_thread_interrupter) {
48 OS::Print("ThreadInterrupter interrupting %p\n", state->id); 48 OS::Print("ThreadInterrupter interrupting %p\n", state->id);
49 } 49 }
50 pthread_kill(state->id, SIGPROF); 50 int result = pthread_kill(state->id, SIGPROF);
51 ASSERT(result == 0);
51 } 52 }
52 53
53 54
54 void ThreadInterrupter::InstallSignalHandler() { 55 void ThreadInterrupter::InstallSignalHandler() {
55 SignalHandler::Install(ThreadInterrupterMacOS::ThreadInterruptSignalHandler); 56 SignalHandler::Install(ThreadInterrupterMacOS::ThreadInterruptSignalHandler);
56 } 57 }
57 58
58 59
59 void ThreadInterrupter::RemoveSignalHandler() { 60 void ThreadInterrupter::RemoveSignalHandler() {
60 SignalHandler::Remove(); 61 SignalHandler::Remove();
61 } 62 }
62 63
63 } // namespace dart 64 } // namespace dart
64 65
65 #endif // defined(TARGET_OS_MACOS) 66 #endif // defined(TARGET_OS_MACOS)
66 67
OLDNEW
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698