Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Side by Side Diff: runtime/vm/thread_interrupter_android.cc

Issue 1276753003: Correct thread state update order (fixes Windows crashes). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Mac, Android. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/thread.cc ('k') | runtime/vm/thread_interrupter_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_ANDROID) 6 #if defined(TARGET_OS_ANDROID)
7 7
8 #include <sys/syscall.h> // NOLINT 8 #include <sys/syscall.h> // NOLINT
9 9
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 state->callback(its, state->data); 43 state->callback(its, state->data);
44 } 44 }
45 }; 45 };
46 46
47 47
48 void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) { 48 void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) {
49 if (FLAG_trace_thread_interrupter) { 49 if (FLAG_trace_thread_interrupter) {
50 OS::Print("ThreadInterrupter interrupting %p\n", 50 OS::Print("ThreadInterrupter interrupting %p\n",
51 reinterpret_cast<void*>(state->id)); 51 reinterpret_cast<void*>(state->id));
52 } 52 }
53 syscall(__NR_tgkill, getpid(), state->id, SIGPROF); 53 int resut = syscall(__NR_tgkill, getpid(), state->id, SIGPROF);
54 ASSERT(result == 0);
54 } 55 }
55 56
56 57
57 void ThreadInterrupter::InstallSignalHandler() { 58 void ThreadInterrupter::InstallSignalHandler() {
58 SignalHandler::Install( 59 SignalHandler::Install(
59 ThreadInterrupterAndroid::ThreadInterruptSignalHandler); 60 ThreadInterrupterAndroid::ThreadInterruptSignalHandler);
60 } 61 }
61 62
62 63
63 void ThreadInterrupter::RemoveSignalHandler() { 64 void ThreadInterrupter::RemoveSignalHandler() {
64 SignalHandler::Remove(); 65 SignalHandler::Remove();
65 } 66 }
66 67
67 } // namespace dart 68 } // namespace dart
68 69
69 #endif // defined(TARGET_OS_ANDROID) 70 #endif // defined(TARGET_OS_ANDROID)
OLDNEW
« no previous file with comments | « runtime/vm/thread.cc ('k') | runtime/vm/thread_interrupter_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698