content/browser/renderer_host/java/java_bound_object.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/java/java_bound_object.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/java/java_bound_object.cc

diff --git a/content/browser/renderer_host/java/java_bound_object.cc b/content/browser/renderer_host/java/java_bound_object.cc

index 5d50948e92e90e0457d00c7275879e7ca6929fc7..4a239a52e52494d68d915c84dd52c08191049f26 100644

--- a/content/browser/renderer_host/java/java_bound_object.cc

+++ b/content/browser/renderer_host/java/java_bound_object.cc

@@ -271,9 +271,9 @@ jvalue CoerceJavaScriptNumberToJavaValue(const NPVariant& variant,

result.l = coerce_to_string ?

ConvertUTF8ToJavaString(

AttachCurrentThread(),

- is_double ? StringPrintf("%.6lg", NPVARIANT_TO_DOUBLE(variant)) :

- base::Int64ToString(NPVARIANT_TO_INT32(variant))).

- Release() :

+ is_double ?

+ base::StringPrintf("%.6lg", NPVARIANT_TO_DOUBLE(variant)) :

+ base::Int64ToString(NPVARIANT_TO_INT32(variant))).Release() :

NULL;

break;

case JavaType::TypeBoolean: