Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6619)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/omaha_query_params.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, once more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/metrics/variations/uniformity_field_trials.cc ('k') | chrome/common/thumbnail_score.cc » ('j') | ipc/ipc_message_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/omaha_query_params.cc
diff --git a/chrome/common/omaha_query_params.cc b/chrome/common/omaha_query_params.cc
index fe59e1c062b86e6a4593cad3455f074e0a6f937b..c13aedab0cb7d13aee043598d4c9137e68b36856 100644
--- a/chrome/common/omaha_query_params.cc
+++ b/chrome/common/omaha_query_params.cc
@@ -91,12 +91,13 @@ const char* GetChannelString() {
namespace chrome {
std::string OmahaQueryParams::Get(ProdId prod) {
- return StringPrintf("os=%s&arch=%s&prod=%s&prodchannel=%s&prodversion=%s",
- kOs,
- kArch,
- GetProdIdString(prod),
- GetChannelString(),
- chrome::VersionInfo().Version().c_str());
+ return base::StringPrintf(
+ "os=%s&arch=%s&prod=%s&prodchannel=%s&prodversion=%s",
+ kOs,
+ kArch,
+ GetProdIdString(prod),
+ GetChannelString(),
+ chrome::VersionInfo().Version().c_str());
}
} // namespace chrome
« no previous file with comments | « chrome/common/metrics/variations/uniformity_field_trials.cc ('k') | chrome/common/thumbnail_score.cc » ('j') | ipc/ipc_message_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698