chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/initializing_rules_registry.cc ('k') | chrome/browser/extensions/api/font_settings/font_settings_api.cc » ('j') | ipc/ipc_message_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

index b95bc7c47a37a608fe846dc1f3633b3c4f617d1b..53bcd1f39e85dbced90d79271ae077b3084e58c1 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

@@ -41,7 +41,7 @@ std::string RulesRegistryWithCache::AddRules(

const RuleId& rule_id = *((*i)->id);

RulesDictionaryKey key(extension_id, rule_id);

if (rules_.find(key) != rules_.end())

- return StringPrintf(kDuplicateRuleId, rule_id.c_str());

+ return base::StringPrintf(kDuplicateRuleId, rule_id.c_str());

}

std::string error = AddRulesImpl(extension_id, rules);