chrome/browser/download/download_path_reservation_tracker_unittest.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_path_reservation_tracker_unittest.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/extensions/api/declarative/initializing_rules_registry.cc » ('j') | ipc/ipc_message_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_path_reservation_tracker_unittest.cc

diff --git a/chrome/browser/download/download_path_reservation_tracker_unittest.cc b/chrome/browser/download/download_path_reservation_tracker_unittest.cc

index 60229318ead5257c4503e754887627818f3b1f39..4209317254cf42450a2387183ec8d1e1103bb149 100644

--- a/chrome/browser/download/download_path_reservation_tracker_unittest.cc

+++ b/chrome/browser/download/download_path_reservation_tracker_unittest.cc

@@ -340,10 +340,12 @@ TEST_F(DownloadPathReservationTrackerTest, UnresolvedConflicts) {

base::FilePath reserved_path;

base::FilePath expected_path;

bool verified = false;

- if (i > 0)

- expected_path = path.InsertBeforeExtensionASCII(StringPrintf(" (%d)", i));

- else

+ if (i > 0) {

+ expected_path =

+ path.InsertBeforeExtensionASCII(base::StringPrintf(" (%d)", i));

+ } else {

expected_path = path;

+ }

items[i].reset(CreateDownloadItem(i));

EXPECT_FALSE(IsPathInUse(expected_path));

CallGetReservedPath(*items[i], path, true, &reserved_path, &verified);