chrome/browser/download/download_browsertest.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_browsertest.cc

diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc

index 35354a464c33c403654a30083dbb49b9d71bd4c4..9b2f6a77015e8038e4f6e1c157da7411ece6577f 100644

--- a/chrome/browser/download/download_browsertest.cc

+++ b/chrome/browser/download/download_browsertest.cc

@@ -2724,8 +2724,9 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadTest_Renaming) {

ASSERT_TRUE(item);

ASSERT_TRUE(item->IsComplete());

base::FilePath full_path(item->GetFullPath());

- EXPECT_EQ(std::string("a_zip_file") + (index == 0 ? std::string(".zip") :

- StringPrintf(" (%d).zip", index)),

+ EXPECT_EQ(std::string("a_zip_file") +

+ (index == 0 ? std::string(".zip") :

+ base::StringPrintf(" (%d).zip", index)),

full_path.BaseName().AsUTF8Unsafe());

ASSERT_TRUE(file_util::PathExists(full_path));

ASSERT_TRUE(VerifyFile(full_path, origin_contents, origin_contents.size()));