Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4593)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, once more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index e95c54b9b93de04800fe0dce73d59d80c01f60a5..976148c909daa613278693f32137591b14a52cd8 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -611,7 +611,7 @@ void DevToolsWindow::DoAction() {
std::string SkColorToRGBAString(SkColor color) {
// We convert the alpha using DoubleToString because StringPrintf will use
// locale specific formatters (e.g., use , instead of . in German).
- return StringPrintf("rgba(%d,%d,%d,%s)", SkColorGetR(color),
+ return base::StringPrintf("rgba(%d,%d,%d,%s)", SkColorGetR(color),
SkColorGetG(color), SkColorGetB(color),
base::DoubleToString(SkColorGetA(color) / 255.0).c_str());
}
@@ -632,7 +632,7 @@ GURL DevToolsWindow::GetDevToolsUrl(Profile* profile,
bool experiments_enabled =
command_line.HasSwitch(switches::kEnableDevToolsExperiments);
- std::string url_string = StringPrintf("%sdevtools.html?"
+ std::string url_string = base::StringPrintf("%sdevtools.html?"
"dockSide=%s&toolbarColor=%s&textColor=%s%s%s",
chrome::kChromeUIDevToolsURL,
SideToString(dock_side).c_str(),
@@ -651,7 +651,7 @@ void DevToolsWindow::UpdateTheme() {
tp->GetColor(ThemeProperties::COLOR_TOOLBAR);
SkColor color_tab_text =
tp->GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT);
- std::string command = StringPrintf(
+ std::string command = base::StringPrintf(
"InspectorFrontendAPI.setToolbarColors(\"%s\", \"%s\")",
SkColorToRGBAString(color_toolbar).c_str(),
SkColorToRGBAString(color_tab_text).c_str());

Powered by Google App Engine
This is Rietveld 408576698