Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Side by Side Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, once more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/searchbox/searchbox_extension.h" 5 #include "chrome/renderer/searchbox/searchbox_extension.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 return v8::String::New(s.data(), s.size()); 59 return v8::String::New(s.data(), s.size());
60 } 60 }
61 61
62 void Dispatch(WebKit::WebFrame* frame, const WebKit::WebString& script) { 62 void Dispatch(WebKit::WebFrame* frame, const WebKit::WebString& script) {
63 if (!frame) return; 63 if (!frame) return;
64 frame->executeScript(WebKit::WebScriptSource(script)); 64 frame->executeScript(WebKit::WebScriptSource(script));
65 } 65 }
66 66
67 v8::Handle<v8::String> GenerateThumbnailURL(uint64 most_visited_item_id) { 67 v8::Handle<v8::String> GenerateThumbnailURL(uint64 most_visited_item_id) {
68 return UTF8ToV8String( 68 return UTF8ToV8String(
69 StringPrintf("chrome-search://thumb/%s", 69 base::StringPrintf("chrome-search://thumb/%s",
70 base::Uint64ToString(most_visited_item_id).c_str())); 70 base::Uint64ToString(most_visited_item_id).c_str()));
71 } 71 }
72 72
73 v8::Handle<v8::String> GenerateFaviconURL(uint64 most_visited_item_id) { 73 v8::Handle<v8::String> GenerateFaviconURL(uint64 most_visited_item_id) {
74 return UTF8ToV8String( 74 return UTF8ToV8String(
75 StringPrintf("chrome-search://favicon/%s", 75 base::StringPrintf("chrome-search://favicon/%s",
76 base::Uint64ToString(most_visited_item_id).c_str())); 76 base::Uint64ToString(most_visited_item_id).c_str()));
77 } 77 }
78 78
79 const GURL MostVisitedItemIDToURL( 79 const GURL MostVisitedItemIDToURL(
80 const std::vector<InstantMostVisitedItem>& most_visited_items, 80 const std::vector<InstantMostVisitedItem>& most_visited_items,
81 uint64 most_visited_item_id) { 81 uint64 most_visited_item_id) {
82 for (size_t i = 0; i < most_visited_items.size(); ++i) { 82 for (size_t i = 0; i < most_visited_items.size(); ++i) {
83 if (most_visited_items[i].most_visited_item_id == most_visited_item_id) 83 if (most_visited_items[i].most_visited_item_id == most_visited_item_id)
84 return most_visited_items[i].url; 84 return most_visited_items[i].url;
85 } 85 }
86 return GURL(); 86 return GURL();
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 void SearchBoxExtension::DispatchThemeChange(WebKit::WebFrame* frame) { 1157 void SearchBoxExtension::DispatchThemeChange(WebKit::WebFrame* frame) {
1158 Dispatch(frame, kDispatchThemeChangeEventScript); 1158 Dispatch(frame, kDispatchThemeChangeEventScript);
1159 } 1159 }
1160 1160
1161 // static 1161 // static
1162 void SearchBoxExtension::DispatchMostVisitedChanged( 1162 void SearchBoxExtension::DispatchMostVisitedChanged(
1163 WebKit::WebFrame* frame) { 1163 WebKit::WebFrame* frame) {
1164 Dispatch(frame, kDispatchMostVisitedChangedScript); 1164 Dispatch(frame, kDispatchMostVisitedChangedScript);
1165 } 1165 }
1166 } // namespace extensions_v8 1166 } // namespace extensions_v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698