Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: base/debug/trace_event_android.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, once more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/debug/trace_event_impl.h" 5 #include "base/debug/trace_event_impl.h"
6 6
7 #include <fcntl.h> 7 #include <fcntl.h>
8 8
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "base/format_macros.h" 10 #include "base/format_macros.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/stringprintf.h" 12 #include "base/stringprintf.h"
13 13
14 namespace { 14 namespace {
15 15
16 int g_atrace_fd = -1; 16 int g_atrace_fd = -1;
17 const char* kATraceMarkerFile = "/sys/kernel/debug/tracing/trace_marker"; 17 const char* kATraceMarkerFile = "/sys/kernel/debug/tracing/trace_marker";
18 18
19 void WriteEvent(char phase, 19 void WriteEvent(char phase,
20 const char* category, 20 const char* category,
21 const char* name, 21 const char* name,
22 unsigned long long id, 22 unsigned long long id,
23 int num_args, 23 int num_args,
24 const char** arg_names, 24 const char** arg_names,
25 const unsigned char* arg_types, 25 const unsigned char* arg_types,
26 const unsigned long long* arg_values, 26 const unsigned long long* arg_values,
27 unsigned char flags) { 27 unsigned char flags) {
28 std::string out = StringPrintf("%c|%d|%s", phase, getpid(), name); 28 std::string out = base::StringPrintf("%c|%d|%s", phase, getpid(), name);
29 if (flags & TRACE_EVENT_FLAG_HAS_ID) 29 if (flags & TRACE_EVENT_FLAG_HAS_ID)
30 base::StringAppendF(&out, "-%" PRIx64, static_cast<uint64>(id)); 30 base::StringAppendF(&out, "-%" PRIx64, static_cast<uint64>(id));
31 out += '|'; 31 out += '|';
32 32
33 for (int i = 0; i < num_args; ++i) { 33 for (int i = 0; i < num_args; ++i) {
34 if (i) 34 if (i)
35 out += ';'; 35 out += ';';
36 out += arg_names[i]; 36 out += arg_names[i];
37 out += '='; 37 out += '=';
38 base::debug::TraceEvent::TraceValue value; 38 base::debug::TraceEvent::TraceValue value;
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 case TRACE_EVENT_PHASE_INSTANT: 102 case TRACE_EVENT_PHASE_INSTANT:
103 // Simulate an instance event with a pair of begin/end events. 103 // Simulate an instance event with a pair of begin/end events.
104 WriteEvent('B', category, name, id, 104 WriteEvent('B', category, name, id,
105 num_args, arg_names, arg_types, arg_values, flags); 105 num_args, arg_names, arg_types, arg_values, flags);
106 write(g_atrace_fd, "E", 1); 106 write(g_atrace_fd, "E", 1);
107 break; 107 break;
108 108
109 case TRACE_EVENT_PHASE_COUNTER: 109 case TRACE_EVENT_PHASE_COUNTER:
110 for (int i = 0; i < num_args; ++i) { 110 for (int i = 0; i < num_args; ++i) {
111 DCHECK(arg_types[i] == TRACE_VALUE_TYPE_INT); 111 DCHECK(arg_types[i] == TRACE_VALUE_TYPE_INT);
112 std::string out = StringPrintf("C|%d|%s-%s", 112 std::string out = base::StringPrintf("C|%d|%s-%s",
113 getpid(), name, arg_names[i]); 113 getpid(), name, arg_names[i]);
114 if (flags & TRACE_EVENT_FLAG_HAS_ID) 114 if (flags & TRACE_EVENT_FLAG_HAS_ID)
115 StringAppendF(&out, "-%" PRIx64, static_cast<uint64>(id)); 115 StringAppendF(&out, "-%" PRIx64, static_cast<uint64>(id));
116 StringAppendF(&out, "|%d|%s", 116 StringAppendF(&out, "|%d|%s",
117 static_cast<int>(arg_values[i]), category); 117 static_cast<int>(arg_values[i]), category);
118 write(g_atrace_fd, out.c_str(), out.size()); 118 write(g_atrace_fd, out.c_str(), out.size());
119 } 119 }
120 break; 120 break;
121 121
122 default: 122 default:
123 // Do nothing. 123 // Do nothing.
124 break; 124 break;
125 } 125 }
126 } 126 }
127 127
128 // Must be called with lock_ locked. 128 // Must be called with lock_ locked.
129 void TraceLog::ApplyATraceEnabledFlag(unsigned char* category_enabled) { 129 void TraceLog::ApplyATraceEnabledFlag(unsigned char* category_enabled) {
130 if (g_atrace_fd != -1) 130 if (g_atrace_fd != -1)
131 *category_enabled |= ATRACE_ENABLED; 131 *category_enabled |= ATRACE_ENABLED;
132 else 132 else
133 *category_enabled &= ~ATRACE_ENABLED; 133 *category_enabled &= ~ATRACE_ENABLED;
134 } 134 }
135 135
136 } // namespace debug 136 } // namespace debug
137 } // namespace base 137 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698