Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 12767004: In ArrayConstructor_StubFailure the transition elements kind was (Closed)

Created:
7 years, 9 months ago by mvstanton
Modified:
7 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

In ArrayConstructor_StubFailure the transition elements kind was ignored on allocation. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13931

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/builtins.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, This is a simple bug fix in a function you had a look ...
7 years, 9 months ago (2013-03-13 12:16:18 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/12767004/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/12767004/diff/1/src/builtins.cc#newcode210 src/builtins.cc:210: } Move this below the if ...
7 years, 9 months ago (2013-03-13 12:49:35 UTC) #2
mvstanton
7 years, 9 months ago (2013-03-13 13:03:46 UTC) #3
Thanks Toon, I updated the code, it's a good nit you found :). I'll check in.
--Michael

https://codereview.chromium.org/12767004/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/12767004/diff/1/src/builtins.cc#newcode210
src/builtins.cc:210: }
On 2013/03/13 12:49:35, Toon Verwaest wrote:
> Move this below the if below.

Done.

Powered by Google App Engine
This is Rietveld 408576698