Make Source.getDirectory synchronous.

lib/src/system_cache.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.system_cache;
 
-import 'dart:async';
 import 'dart:io';
 
 import 'package:path/path.dart' as path;
 
 import 'io.dart';
 import 'io.dart' as io show createTempDir;
 import 'log.dart' as log;
 import 'package.dart';
 import 'source/cached.dart';
 import 'source/git.dart';
@@ skipping 54 matching lines @@
   /// Registers a new source.
   ///
   /// This source must not have the same name as a source that's already been
   /// registered.
   void register(Source source) {
     source.bind(this);
     sources.register(source);
   }
 
   /// Determines if the system cache contains the package identified by [id].
-  Future<bool> contains(PackageId id) {
+  ///
+  /// Depending on the source, this may throw an [ArgumentError] if [id] isn't
+  /// resolved using [Source.resolveId].
+  bool contains(PackageId id) {
     var source = sources[id.source];
 
     if (source is! CachedSource) {
       throw new ArgumentError("Package $id is not cacheable.");
     }
 
     return source.isInSystemCache(id);
   }
 
   /// Create a new temporary directory within the system cache.
   ///
   /// The system cache maintains its own temporary directory that it uses to
   /// stage packages into while downloading. It uses this instead of the OS's
   /// system temp directory to ensure that it's on the same volume as the pub
   /// system cache so that it can move the directory from it.
   String createTempDir() {
     var temp = ensureDir(tempDir);
     return io.createTempDir(temp, 'dir');
   }
 
   /// Deletes the system cache's internal temp directory.
   void deleteTempDir() {
     log.fine('Clean up system cache temp directory $tempDir.');
     if (dirExists(tempDir)) deleteEntry(tempDir);
   }
 }