Make Source.getDirectory synchronous.

lib/src/source/hosted.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.source.hosted;
 
 import 'dart:async';
 import 'dart:io' as io;
 import "dart:convert";
 
@@ skipping 65 matching lines @@
       _throwFriendlyError(error, stackTrace, id.name, parsed.last);
     }
 
     return new Pubspec.fromMap(
         version['pubspec'], systemCache.sources,
         expectedName: id.name, location: url);
   }
 
   /// Downloads the package identified by [id] to the system cache.
   Future<Package> downloadToSystemCache(PackageId id) async {
-    if (!(await isInSystemCache(id))) {
-      var packageDir = _getDirectory(id);
+    if (!isInSystemCache(id)) {
+      var packageDir = getDirectory(id);
       ensureDir(path.dirname(packageDir));
       var parsed = _parseDescription(id.description);
       await _download(parsed.last, parsed.first, id.version, packageDir);
     }
 
-    return new Package.load(id.name, _getDirectory(id), systemCache.sources);
+    return new Package.load(id.name, getDirectory(id), systemCache.sources);
   }
 
   /// The system cache directory for the hosted source contains subdirectories
   /// for each separate repository URL that's used on the system.
   ///
   /// Each of these subdirectories then contains a subdirectory for each
   /// package downloaded from that site.
-  Future<String> getDirectory(PackageId id) =>
-      new Future.value(_getDirectory(id));
-
-  String _getDirectory(PackageId id) {
+  String getDirectory(PackageId id) {
     var parsed = _parseDescription(id.description);
     var dir = _urlToDirectory(parsed.last);
     return path.join(systemCacheRoot, dir, "${parsed.first}-${id.version}");
   }
 
   String packageName(description) => _parseDescription(description).first;
 
   bool descriptionsEqual(description1, description2) =>
       _parseDescription(description1) == _parseDescription(description2);
 
@@ skipping 234 matching lines @@
   var name = description["name"];
   if (name is! String) {
     throw new FormatException("The 'name' key must have a string value.");
   }
 
   var url = description["url"];
   if (url == null) url = HostedSource.defaultUrl;
 
   return new Pair<String, String>(name, url);
 }