Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276653003: Update version of Go to 1.5 (Closed)

Created:
5 years, 4 months ago by gautham
Modified:
5 years, 4 months ago
Reviewers:
rogulenko, jamesr, gauthamt
CC:
Aaron Boodman, abarth-chromium, ataly, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

* Update to Go 1.5 version * Shared library support exists. So remove use of gomobile * Fix sample examples to not use gomobile * Some build script fixes R=jamesr@chromium.org, rogulenko@google.com Committed: https://chromium.googlesource.com/external/mojo/+/fec04e6b5366ca38dcafa17603555954dd3af0a4

Patch Set 1 #

Patch Set 2 : Remove dependencies #

Patch Set 3 : go.mobile no longer needed #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M examples/go/echo_client.go View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M examples/go/echo_server.go View 1 2 2 chunks +0 lines, -3 lines 3 comments Download
M examples/go/http_handler.go View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M examples/go/http_server.go View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/go/go.py View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/go/rules.gni View 1 chunk +1 line, -4 lines 0 comments Download
M tools/go/VERSION_LINUX View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
gautham
5 years, 4 months ago (2015-08-05 23:50:14 UTC) #2
jamesr
lgtm https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go File examples/go/echo_server.go (right): https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go#newcode65 examples/go/echo_server.go:65: func main() { when is func main() invoked ...
5 years, 4 months ago (2015-08-05 23:53:41 UTC) #3
gauthamt
https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go File examples/go/echo_server.go (right): https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go#newcode65 examples/go/echo_server.go:65: func main() { On 2015/08/05 23:53:41, jamesr wrote: > ...
5 years, 4 months ago (2015-08-06 00:08:04 UTC) #5
gautham
https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go File examples/go/echo_server.go (right): https://codereview.chromium.org/1276653003/diff/40001/examples/go/echo_server.go#newcode65 examples/go/echo_server.go:65: func main() { On 2015/08/05 23:53:41, jamesr wrote: > ...
5 years, 4 months ago (2015-08-06 00:10:17 UTC) #6
rogulenko
lgtm
5 years, 4 months ago (2015-08-06 01:14:22 UTC) #7
gautham
5 years, 4 months ago (2015-08-06 15:44:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fec04e6b5366ca38dcafa17603555954dd3af0a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698