content/renderer/pepper/video_encoder_shim.cc - Issue 1276633004: convince gcc that cpu_used et al are always initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/video_encoder_shim.cc

Issue 1276633004: convince gcc that cpu_used et al are always initialized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/video_encoder_shim.cc

diff --git a/content/renderer/pepper/video_encoder_shim.cc b/content/renderer/pepper/video_encoder_shim.cc

index 43c63474a4533293ad3fb3b6235e5235ad148c0d..af45b84eebe77c7ef358df8468ce8fa5d2fda7d0 100644

--- a/content/renderer/pepper/video_encoder_shim.cc

+++ b/content/renderer/pepper/video_encoder_shim.cc

@@ -77,6 +77,9 @@ void GetVpxCodecParameters(media::VideoCodecProfile codec,

break;

default:

*vpx_codec = nullptr;

+ *min_quantizer = kVp9DefaultMinQuantizer;

+ *max_quantizer = kVp9DefaultMaxQuantizer;

+ *cpu_used = kVp9DefaultCpuUsed;

bbudge-google 2015/08/06 12:26:25 nit: Just zero them to make it clear this is an er

NOTREACHED();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »