Issue 1276633002: Revert of Implement caching of stroked paths in the tessellated path renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276633002: Revert of Implement caching of stroked paths in the tessellated path renderer. (Closed)

Created:
5 years, 4 months ago by Stephen White

Modified:
5 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Implement caching of stroked paths in the tessellated path renderer. (patchset #4 id:60001 of https://codereview.chromium.org/1275553002/ ) Reason for revert: Breaking/asserting in Debug on DM. Original issue's description: > Implement caching of stroked paths in the tessellated path renderer. > > This requires adding the stroke info to the cache key, and doing the > stroking and dashing before rendering as triangles. > > BUG=skia:3755 > > Committed: https://skia.googlesource.com/skia/+/29e0d3f267a03546f236023347cdb4595ece2fd1 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3755 Committed: https://skia.googlesource.com/skia/+/59cd36765c10f6451f72ffde446b9ae8ce5599c8

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -71 lines)			Patch
M	include/gpu/GrTestUtils.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrTessellatingPathRenderer.cpp	View	11 chunks	+11 lines, -36 lines	0 comments	Download
M	src/gpu/GrTestUtils.cpp	View	2 chunks	+8 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Created Revert of Implement caching of stroked paths in the tessellated path renderer.

5 years, 4 months ago (2015-08-05 20:37:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276633002/1

5 years, 4 months ago (2015-08-05 20:37:45 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-05 20:37:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/59cd36765c10f6451f72ffde446b9ae8ce5599c8

Expand Messages | Collapse Messages