Issue 127663002: Implement DriveAPIService::UninstallApp().

Issue 127663002: Implement DriveAPIService::UninstallApp(). (Closed)

Created:
6 years, 11 months ago by kinaba

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement DriveAPIService::UninstallApp(). BUG=324166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243571

Patch Set 3 : Typo fix #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -5 lines)			Patch
M	chrome/browser/drive/drive_api_service.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	google_apis/drive/drive_api_requests.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	google_apis/drive/drive_api_requests.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	google_apis/drive/drive_api_url_generator.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	google_apis/drive/drive_api_url_generator.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	google_apis/drive/drive_api_url_generator_unittest.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinaba

PTAL. Not yet tested on the real environment because the server with the apps.delete endpoint ...

6 years, 11 months ago (2014-01-08 06:00:25 UTC) #1

hashimoto

lgtm https://codereview.chromium.org/127663002/diff/1/google_apis/drive/drive_api_url_generator.cc File google_apis/drive/drive_api_url_generator.cc (right): https://codereview.chromium.org/127663002/diff/1/google_apis/drive/drive_api_url_generator.cc#newcode20 google_apis/drive/drive_api_url_generator.cc:20: const char kDriveV2AppsDeleteUrlFormat[] = "/drive/v2internal/apps/%s"; Can we have ...

6 years, 11 months ago (2014-01-08 07:20:47 UTC) #2

kinaba

https://codereview.chromium.org/127663002/diff/1/google_apis/drive/drive_api_url_generator.cc File google_apis/drive/drive_api_url_generator.cc (right): https://codereview.chromium.org/127663002/diff/1/google_apis/drive/drive_api_url_generator.cc#newcode20 google_apis/drive/drive_api_url_generator.cc:20: const char kDriveV2AppsDeleteUrlFormat[] = "/drive/v2internal/apps/%s"; On 2014/01/08 07:20:47, hashimoto ...

6 years, 11 months ago (2014-01-08 09:03:46 UTC) #3

hashimoto

lgtm https://codereview.chromium.org/127663002/diff/110001/google_apis/drive/drive_api_url_generator.cc File google_apis/drive/drive_api_url_generator.cc (right): https://codereview.chromium.org/127663002/diff/110001/google_apis/drive/drive_api_url_generator.cc#newcode20 google_apis/drive/drive_api_url_generator.cc:20: // apps.delete API is exposed through a special ...

6 years, 11 months ago (2014-01-08 09:06:32 UTC) #4

kinaba

https://codereview.chromium.org/127663002/diff/110001/google_apis/drive/drive_api_url_generator.cc File google_apis/drive/drive_api_url_generator.cc (right): https://codereview.chromium.org/127663002/diff/110001/google_apis/drive/drive_api_url_generator.cc#newcode20 google_apis/drive/drive_api_url_generator.cc:20: // apps.delete API is exposed through a special endpoing ...

6 years, 11 months ago (2014-01-08 09:09:13 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/127663002/170001

6 years, 11 months ago (2014-01-08 13:14:59 UTC) #6

Message was sent while issue was closed.

Change committed as 243571

Expand Messages | Collapse Messages