Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1276613002: Change sizing of views::Separator (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change sizing of views::Separator Using the allocated height/width in GetPreferredSize is a bit hokey and could potentially lead to unexpected behavior. This also fixes the use of borders on views::Separators. See also https://codereview.chromium.org/1270783005/ BUG=none TBR=sky@chromium.org Committed: https://crrev.com/5612b1032ded056a736d7877dc9748ecb47bcc9b Cr-Commit-Position: refs/heads/master@{#341952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/views/controls/separator.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
5 years, 4 months ago (2015-08-05 18:57:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276613002/1
5 years, 4 months ago (2015-08-05 18:58:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 20:14:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5612b1032ded056a736d7877dc9748ecb47bcc9b Cr-Commit-Position: refs/heads/master@{#341952}
5 years, 4 months ago (2015-08-05 20:15:07 UTC) #7
sky
5 years, 4 months ago (2015-08-05 21:38:26 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698