Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1276553007: Revert broken Linux hidpi changes. (Closed)

Created:
5 years, 4 months ago by Michael Moss
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert broken Linux hidpi changes. This reverts the following: commit 5cb0c01e4233ff3eb1e7f6f677b4cf9dae9ffaf2 Author: oshima <oshima@chromium.org>; Date: Fri May 15 15:16:07 2015 -0700 Compute the base dpi from X commit 42de8ba1ba55502417670a820b5bd57017a6cd29 Author: oshima <oshima@chromium.org>; Date: Wed Jul 22 15:17:49 2015 -0700 Use org.gnome.desktop.interface text-scaling-factor directly R=oshima@chromium.org, stapelberg@google.com BUG=485183 Committed: https://crrev.com/6b72d5275f43b0fdcaa6029859e5e506f005c7bb Cr-Commit-Position: refs/heads/master@{#342381}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -46 lines) Patch
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 5 chunks +7 lines, -34 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Michael Moss
5 years, 4 months ago (2015-08-06 22:58:46 UTC) #1
Michael Moss
Note, this wasn't a 100% clean revert, since there were several intervening changes. Please check ...
5 years, 4 months ago (2015-08-06 23:00:45 UTC) #2
stapelberg
lgtm https://codereview.chromium.org/1276553007/diff/1/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/1276553007/diff/1/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode53 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:53: #include "ui/gfx/x/x11_types.h" You might be able to remove ...
5 years, 4 months ago (2015-08-07 10:38:22 UTC) #4
Michael Moss
https://codereview.chromium.org/1276553007/diff/1/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/1276553007/diff/1/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode53 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:53: #include "ui/gfx/x/x11_types.h" On 2015/08/07 10:38:22, stapelberg wrote: > You ...
5 years, 4 months ago (2015-08-07 16:45:40 UTC) #5
Michael Moss
+erg for OWNERS
5 years, 4 months ago (2015-08-07 16:46:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276553007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276553007/20001
5 years, 4 months ago (2015-08-07 17:10:43 UTC) #9
Elliot Glaysher
lgtm
5 years, 4 months ago (2015-08-07 17:20:02 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 17:50:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276553007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276553007/20001
5 years, 4 months ago (2015-08-07 17:56:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 18:05:18 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:06:06 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b72d5275f43b0fdcaa6029859e5e506f005c7bb
Cr-Commit-Position: refs/heads/master@{#342381}

Powered by Google App Engine
This is Rietveld 408576698