Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1276553005: Don’t use DYLD_INSERT_LIBRARIES with a system executable (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Don’t use DYLD_INSERT_LIBRARIES with a system executable. OS X 10.11 introduces System Integrity Protection. One facet of that forbids code injection into system executables. A Crashpad test checks that information can be recovered from dyld in early-launch crashes by requesting dyld load a nonexistent library with DYLD_INSERT_LIBRARIES. The executable was meaningless but a system-provided executable, /usr/bin/true, was used for convenience. This test hung on OS X 10.11 because DYLD_INSERT_LIBRARIES was ignored for the system executable, and no crash occurred. The test waited for a crash that would never come. A custom no-op executable, crashpad_snapshot_test_no_op, is provided as an executable that does work with DYLD_INSERT_LIBRARIES. BUG=crashpad:41 TEST=crashpad_snapshot_test MachOImageAnnotationsReader.CrashDyld R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5e8e72f91c73bff9dbdb8d44afb1ce48f694bc8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 4 chunks +15 lines, -3 lines 0 comments Download
A snapshot/mac/mach_o_image_annotations_reader_test_no_op.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M snapshot/snapshot_test.gyp View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-05 19:56:36 UTC) #2
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-05 20:27:47 UTC) #3
Mark Mentovai
5 years, 4 months ago (2015-08-05 22:24:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e8e72f91c73bff9dbdb8d44afb1ce48f694bc8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698