Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276543005: Upstream WebOmniboxEditController. (Closed)

Created:
5 years, 4 months ago by sdefresne
Modified:
5 years, 4 months ago
Reviewers:
blundell
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream WebOmniboxEditController. WebOmniboxEditController is a sub-class of OmniboxEditController that provides iOS specific extensions to its base class. BUG=517004 Committed: https://crrev.com/7b318c8c81efb400737ea43ec1bdb31233127c6f Cr-Commit-Position: refs/heads/master@{#342314}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ios/chrome/ios_chrome.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look.
5 years, 4 months ago (2015-08-06 17:38:26 UTC) #2
blundell
lgtm with question addressed https://codereview.chromium.org/1276543005/diff/1/ios/chrome/ios_chrome.gyp File ios/chrome/ios_chrome.gyp (left): https://codereview.chromium.org/1276543005/diff/1/ios/chrome/ios_chrome.gyp#oldcode69 ios/chrome/ios_chrome.gyp:69: '../../components/components.gyp:open_from_clipboard', why all the subtractions ...
5 years, 4 months ago (2015-08-06 18:56:23 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/1276543005/diff/1/ios/chrome/ios_chrome.gyp File ios/chrome/ios_chrome.gyp (left): https://codereview.chromium.org/1276543005/diff/1/ios/chrome/ios_chrome.gyp#oldcode69 ios/chrome/ios_chrome.gyp:69: '../../components/components.gyp:open_from_clipboard', On 2015/08/06 at ...
5 years, 4 months ago (2015-08-07 07:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276543005/20001
5 years, 4 months ago (2015-08-07 07:24:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 07:44:42 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 07:45:19 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7b318c8c81efb400737ea43ec1bdb31233127c6f
Cr-Commit-Position: refs/heads/master@{#342314}

Powered by Google App Engine
This is Rietveld 408576698