Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1276513002: Oilpan: have WebRemoteFrameImpl use SelfKeepAlive<>. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have WebRemoteFrameImpl use SelfKeepAlive<>. Canonicalize WebRemoteFrameImpl's self-referential persistent as a SelfKeepAlive<>. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/web/WebRemoteFrameImpl.h View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Sorry, overlooked this one while handling WebLocalFrameImpl.
5 years, 4 months ago (2015-08-05 15:11:43 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-05 15:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276513002/1
5 years, 4 months ago (2015-08-05 15:19:13 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 16:42:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200048

Powered by Google App Engine
This is Rietveld 408576698