Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 127643002: Convert some ifdefs to use their V8_OS_* macros equivalents. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Convert some ifdefs to use their V8_OS_* macros equivalents. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/platform-posix.cc View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Is this OK?
6 years, 11 months ago (2014-01-08 04:33:04 UTC) #1
Benedikt Meurer
LGTM, I'll land it.
6 years, 11 months ago (2014-01-09 07:56:25 UTC) #2
Benedikt Meurer
6 years, 11 months ago (2014-01-09 07:57:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698