Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/test/chromedriver/basic_types.h

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/basic_types.cc » ('j') | chrome/test/chromedriver/element_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/basic_types.h
diff --git a/chrome/test/chromedriver/basic_types.h b/chrome/test/chromedriver/basic_types.h
index 8a623c481d3b944f3001b1a620defe9712170ee0..b217f05f6188b35280f4d35cec70cef21946e671 100644
--- a/chrome/test/chromedriver/basic_types.h
+++ b/chrome/test/chromedriver/basic_types.h
@@ -5,12 +5,14 @@
#ifndef CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_
#define CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_
+#include <string>
+
struct WebPoint {
WebPoint();
WebPoint(int x, int y);
~WebPoint();
- void offset(int x_, int y_);
+ void Offset(int x_, int y_);
int x;
int y;
@@ -31,13 +33,18 @@ struct WebRect {
WebRect(const WebPoint& origin, const WebSize& size);
~WebRect();
- int x();
- int y();
- int width();
- int height();
+ int width() const;
+ int height() const;
WebPoint origin;
WebSize size;
};
+struct FrameInfo {
kkania 2013/03/12 18:34:25 i don't think i'd call this a basic type. how abou
kkania 2013/03/12 18:34:25 can you think of a better name?
chrisgao (Use stgao instead) 2013/03/12 23:17:41 Done.
chrisgao (Use stgao instead) 2013/03/12 23:17:41 FrameElement.
+ FrameInfo(const std::string& parent_id, const std::string& xpath);
+
+ std::string parent_id;
+ std::string xpath;
kkania 2013/03/12 18:34:25 at first read, it is a bit unclear what this refer
chrisgao (Use stgao instead) 2013/03/12 23:17:41 chromedriver_frame_id, holding the random value of
+};
+
#endif // CHROME_TEST_CHROMEDRIVER_BASIC_TYPES_H_
« no previous file with comments | « no previous file | chrome/test/chromedriver/basic_types.cc » ('j') | chrome/test/chromedriver/element_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698