Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4543)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index a24f1e2f8b3ca4412bfe02833eb599169a4726b9..5502d9301b9e7fdd510e2120b97fda8cbfbe7ec4 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -167,7 +167,7 @@ Status ExecuteSwitchToWindow(
if (!web_view)
return Status(kNoSuchWindow);
session->window = web_view->GetId();
- session->frame = "";
+ session->SwitchToTopFrame();
session->mouse_position = WebPoint(0, 0);
return Status(kOk);
}
@@ -281,7 +281,8 @@ Status ExecuteIsLoading(
return status;
bool is_pending;
- status = web_view->IsPendingNavigation(session->frame, &is_pending);
+ status = web_view->IsPendingNavigation(
+ session->GetCurrentFrameId(), &is_pending);
if (status.IsError())
return status;
value->reset(new base::FundamentalValue(is_pending));
« no previous file with comments | « chrome/test/chromedriver/session.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698