Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3252)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/basic_types.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index 8baa18a677213995ed82b44791057dbfee4663cb..4a0b3ac74a64595c5ad1169ba3dc747d7f43680b 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -231,7 +231,7 @@ TEST(CommandsTest, SuccessfulFindElement) {
FindElementWebView web_view(true, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.frame = "frame_id1";
+ session.SwitchToSubFrame("frame_id1", "");
base::DictionaryValue params;
params.SetString("using", "id");
params.SetString("value", "a");
@@ -260,7 +260,7 @@ TEST(CommandsTest, SuccessfulFindElements) {
FindElementWebView web_view(false, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.frame = "frame_id2";
+ session.SwitchToSubFrame("frame_id2", "");
base::DictionaryValue params;
params.SetString("using", "name");
params.SetString("value", "b");
@@ -294,7 +294,7 @@ TEST(CommandsTest, SuccessfulFindChildElement) {
FindElementWebView web_view(true, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.frame = "frame_id3";
+ session.SwitchToSubFrame("frame_id3", "");
base::DictionaryValue params;
params.SetString("using", "tag name");
params.SetString("value", "div");
@@ -332,7 +332,7 @@ TEST(CommandsTest, SuccessfulFindChildElements) {
FindElementWebView web_view(false, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.frame = "frame_id4";
+ session.SwitchToSubFrame("frame_id4", "");
base::DictionaryValue params;
params.SetString("using", "class name");
params.SetString("value", "c");
« no previous file with comments | « chrome/test/chromedriver/basic_types.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698