chrome/test/chromedriver/session_commands.cc - Issue 12764021: [chromedriver] Support clicking an element in sub frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index aa0cf12de1ccb5ab8fea15b5b8a663b03e79287d..d48dc933ad8cd57f42d51b3e351fe33eaf755dd6 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -158,7 +158,7 @@ Status ExecuteSwitchToWindow(

if (!web_view)

return Status(kNoSuchWindow);

session->window = web_view->GetId();

- session->frame = "";

+ session->SwitchToTopFrame();

session->mouse_position = WebPoint(0, 0);

return Status(kOk);

}