Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: chrome/test/chromedriver/basic_types.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/basic_types.cc
diff --git a/chrome/test/chromedriver/basic_types.cc b/chrome/test/chromedriver/basic_types.cc
index ef6b2f39a6a8972938560915057cc5bce3d43902..333ca059bf15d8be97a37f485359f931aea9fc7c 100644
--- a/chrome/test/chromedriver/basic_types.cc
+++ b/chrome/test/chromedriver/basic_types.cc
@@ -10,7 +10,7 @@ WebPoint::WebPoint(int x, int y) : x(x), y(y) {}
WebPoint::~WebPoint() {}
-void WebPoint::offset(int x_, int y_) {
+void WebPoint::Offset(int x_, int y_) {
x += x_;
y += y_;
}
@@ -31,10 +31,18 @@ WebRect::WebRect(const WebPoint& origin, const WebSize& size)
WebRect::~WebRect() {}
-int WebRect::x() { return origin.x; }
+int WebRect::width() const { return size.width; }
-int WebRect::y() { return origin.y; }
+int WebRect::height() const { return size.height; }
-int WebRect::width() { return size.width; }
+Frame::Frame() {}
-int WebRect::height() { return size.height; }
+Frame::Frame(const std::string& id,
+ const std::string& parent_id,
+ const std::string& name,
+ int index)
+ : id(id), parent_id(parent_id), name(name), index(index) {}
+
+bool Frame::IsSubFrame() const { return !parent_id.empty(); }
+
+bool Frame::HasName() const { return !name.empty(); }

Powered by Google App Engine
This is Rietveld 408576698