chrome/test/chromedriver/window_commands.cc - Issue 12764021: [chromedriver] Support clicking an element in sub frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 12764021: [chromedriver] Support clicking an element in sub frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/window_commands.cc

diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc

index 54dca1e590cc7a28603a83d5911204e9ef1ce1eb..e74bcfaf49ec95598a422c64d5118943c7e0c70f 100644

--- a/chrome/test/chromedriver/window_commands.cc

+++ b/chrome/test/chromedriver/window_commands.cc

@@ -342,13 +342,13 @@ Status ExecuteMouseMoveTo(

}

if (has_offset) {

- location.offset(x_offset, y_offset);

+ location.Offset(x_offset, y_offset);

} else {

WebSize size;

Status status = GetElementSize(session, web_view, element_id, &size);

if (status.IsError())

return status;

- location.offset(size.width / 2, size.height / 2);

+ location.Offset(size.width / 2, size.height / 2);

}

std::list<MouseEvent> events;