Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 12764003: Added an Isolate parameter to some HashTable/Dictionary methods. TypeFeedbackOracle tweaks. (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Added an Isolate parameter to some HashTable/Dictionary methods. TypeFeedbackOracle tweaks. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13908

Patch Set 1 #

Patch Set 2 : TypeFeedbackOracle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -89 lines) Patch
M src/compilation-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 6 chunks +13 lines, -6 lines 0 comments Download
M src/heap.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M src/objects.h View 10 chunks +18 lines, -9 lines 0 comments Download
M src/objects.cc View 16 chunks +31 lines, -19 lines 0 comments Download
M src/objects-inl.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/type-info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 10 chunks +49 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 9 months ago (2013-03-11 13:21:53 UTC) #1
Michael Starzinger
LGTM.
7 years, 9 months ago (2013-03-11 14:34:41 UTC) #2
Sven Panne
7 years, 9 months ago (2013-03-12 07:06:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698