chrome/browser/ui/cocoa/browser_window_layout.mm - Issue 1276383004: Implemented fullscreen exit animation with AppKit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_layout.mm

Issue 1276383004: Implemented fullscreen exit animation with AppKit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed format issues Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_layout.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_layout.mm b/chrome/browser/ui/cocoa/browser_window_layout.mm

index 55c061c374a43838310e2ef1e4db9a10a62ec4ac..787241212fe7e4c9aae2bd649a993950f26504f5 100644

--- a/chrome/browser/ui/cocoa/browser_window_layout.mm

+++ b/chrome/browser/ui/cocoa/browser_window_layout.mm

@@ -265,7 +265,7 @@ const CGFloat kLocationBarRightOffset = 35;

// Sanity-check |maxY|.

DCHECK_GE(maxY, 0);

- DCHECK_LE(maxY, parameters_.contentViewSize.height + fullscreenYOffset_);

+// DCHECK_LE(maxY, parameters_.contentViewSize.height + fullscreenYOffset_);

erikchen 2015/08/10 18:06:25 huh?

spqchan1 2015/08/11 21:43:48 Removed this.

CGFloat width = parameters_.contentViewSize.width;