Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/ui/cocoa/framed_browser_window.h

Issue 1276383004: Implemented fullscreen exit animation with AppKit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix with comment format Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/framed_browser_window.h
diff --git a/chrome/browser/ui/cocoa/framed_browser_window.h b/chrome/browser/ui/cocoa/framed_browser_window.h
index ec6da688f6e308387b6e555bae23564dec4bb4c7..8826fffb7d289d7081270876690e55ac07c69fe2 100644
--- a/chrome/browser/ui/cocoa/framed_browser_window.h
+++ b/chrome/browser/ui/cocoa/framed_browser_window.h
@@ -35,6 +35,10 @@ const CGFloat kBrowserFrameViewPaintHeight = 60.0;
NSButton* miniaturizeButton_;
NSButton* zoomButton_;
+ // Locks the window's frame and style mask. If it's set to YES, then the
+ // frame and the style mask cannot be changed.
+ BOOL frameAndStyleMaskLock_;
+
CGFloat windowButtonsInterButtonSpacing_;
}
@@ -45,6 +49,20 @@ const CGFloat kBrowserFrameViewPaintHeight = 60.0;
// Tells the window to suppress title drawing.
- (void)setShouldHideTitle:(BOOL)flag;
+// When the lock is set to YES, the frame and style mask of the Window cannot be
+// changed. This is used to prevent AppKit from making these unwanted changes
+// to the window during exit fullscreen transition. It is very important to
+// release this lock after the transition is completed.
+- (void)setFrameAndStyleMaskLock:(BOOL)lock;
+
+// This method is overridden to prevent AppKit from setting the style mask
+// when frameAndStyleMaskLock_ is set to true.
+- (void)setStyleMask:(NSUInteger)styleMask;
+
+// This method is overridden to prevent the AppKit from setting the frame when
+// frameAndStyleMaskLock_ is set to true.
+- (void)setFrame:(NSRect)frameRect display:(BOOL)flag animate:(BOOL)animateFlag;
Andre 2015/08/13 23:03:19 nit: flag is not a good parameter name. I suggest
spqchan1 2015/08/14 01:08:27 Done.
+
// Returns the desired spacing between window control views.
- (CGFloat)windowButtonsInterButtonSpacing;

Powered by Google App Engine
This is Rietveld 408576698