Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/ui/cocoa/full_size_content_window.h

Issue 1276383004: Implemented fullscreen exit animation with AppKit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made some changes according to missed comments on Patch Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/full_size_content_window.h
diff --git a/chrome/browser/ui/cocoa/full_size_content_window.h b/chrome/browser/ui/cocoa/full_size_content_window.h
index 1c8d44d776b01f47a9f246c0c5f87ca6d41568f8..5af2815a486eebe1e0a224f108a5e6110db4260d 100644
--- a/chrome/browser/ui/cocoa/full_size_content_window.h
+++ b/chrome/browser/ui/cocoa/full_size_content_window.h
@@ -21,6 +21,22 @@
//
// This class currently does not support changing the window's style after the
// window has been initialized.
+
+// This view always takes the size of its superview. It is intended to be used
+// as a NSWindow's contentView. It is needed because NSWindow's implementation
+// explicitly resizes the contentView at inopportune times.
+@interface FullSizeContentView : NSView
+
+// This method is directly called by AppKit during a live window resize.
+// Override it to prevent the content view from shrinking.
+- (void)setFrameSize:(NSSize)size;
+
+// This method allows us to set the content view size since setFrameSize is
+// overridden to prevent the view from shrinking
+- (void)forceFrameSize:(NSSize)size;
erikchen 2015/08/12 22:08:53 (I should have made this comment in my first revie
spqchan1 2015/08/13 20:38:48 Done.
spqchan1 2015/08/13 20:38:48 Done.
+
+@end
+
@interface FullSizeContentWindow : ChromeEventProcessingWindow {
@private
// Holds the view that replaces [window contentView]. This view has the same

Powered by Google App Engine
This is Rietveld 408576698