Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ | 5 #ifndef CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ |
| 6 #define CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ | 6 #define CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ |
| 7 | 7 |
| 8 #import "chrome/browser/ui/cocoa/chrome_event_processing_window.h" | 8 #import "chrome/browser/ui/cocoa/chrome_event_processing_window.h" |
| 9 | 9 |
| 10 #include "base/mac/scoped_nsobject.h" | 10 #include "base/mac/scoped_nsobject.h" |
| 11 | 11 |
| 12 // By default, the contentView does not occupy the full size of a framed | 12 // By default, the contentView does not occupy the full size of a framed |
| 13 // window. Chrome still wants to draw in the title bar. Historically, Chrome | 13 // window. Chrome still wants to draw in the title bar. Historically, Chrome |
| 14 // has done this by adding subviews directly to the root view. This causes | 14 // has done this by adding subviews directly to the root view. This causes |
| 15 // several problems. The most egregious is related to layer ordering when the | 15 // several problems. The most egregious is related to layer ordering when the |
| 16 // root view does not have a layer. By giving the contentView the same size as | 16 // root view does not have a layer. By giving the contentView the same size as |
| 17 // the window, there is no longer any need to add subviews to the root view. | 17 // the window, there is no longer any need to add subviews to the root view. |
| 18 // | 18 // |
| 19 // If the window does not have a titlebar, then its contentView already has the | 19 // If the window does not have a titlebar, then its contentView already has the |
| 20 // same size as the window. In this case, this class has no effect. | 20 // same size as the window. In this case, this class has no effect. |
| 21 // | 21 // |
| 22 // This class currently does not support changing the window's style after the | 22 // This class currently does not support changing the window's style after the |
| 23 // window has been initialized. | 23 // window has been initialized. |
| 24 | |
| 25 @interface FullSizeContentView : NSView | |
|
erikchen
2015/08/10 18:06:26
You moved the @interface from the .mm to the .h, b
spqchan1
2015/08/11 21:43:48
Done.
| |
| 26 | |
| 27 // This method allows us to set the content view size since setFrameSize is | |
| 28 // overridden to prevent the view from shrinking | |
| 29 - (void)forceFrameSize:(NSSize)size; | |
| 30 | |
| 31 @end | |
| 32 | |
| 24 @interface FullSizeContentWindow : ChromeEventProcessingWindow { | 33 @interface FullSizeContentWindow : ChromeEventProcessingWindow { |
| 25 @private | 34 @private |
| 26 // Holds the view that replaces [window contentView]. This view has the same | 35 // Holds the view that replaces [window contentView]. This view has the same |
| 27 // size as the window. Empty if there is no titlebar. | 36 // size as the window. Empty if there is no titlebar. |
| 28 base::scoped_nsobject<NSView> chromeWindowView_; | 37 base::scoped_nsobject<NSView> chromeWindowView_; |
| 29 } | 38 } |
| 30 | 39 |
| 31 // Designated initializer. | 40 // Designated initializer. |
| 32 - (instancetype)initWithContentRect:(NSRect)contentRect | 41 - (instancetype)initWithContentRect:(NSRect)contentRect |
| 33 styleMask:(NSUInteger)windowStyle | 42 styleMask:(NSUInteger)windowStyle |
| 34 backing:(NSBackingStoreType)bufferingType | 43 backing:(NSBackingStoreType)bufferingType |
| 35 defer:(BOOL)deferCreation | 44 defer:(BOOL)deferCreation |
| 36 wantsViewsOverTitlebar:(BOOL)wantsViewsOverTitlebar; | 45 wantsViewsOverTitlebar:(BOOL)wantsViewsOverTitlebar; |
| 37 | 46 |
| 38 @end | 47 @end |
| 39 | 48 |
| 40 #endif // CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ | 49 #endif // CHROME_BROWSER_UI_COCOA_FULL_SIZE_CONTENT_WINDOW_H_ |
| OLD | NEW |