Implemented fullscreen exit animation with AppKit

chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_FULLSCREEN_TRANSITION_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_FULLSCREEN_TRANSITION_H_
 
 #import <Cocoa/Cocoa.h>
 
+@class FramedBrowserWindow;
+
 // This class is responsible for managing the custom transition of a
-// BrowserWindow from its normal state into an AppKit Fullscreen state.
+// BrowserWindow from its normal state into an AppKit Fullscreen state
+// and vice versa.
 //
 // By default, when AppKit Fullscreens a window, it creates a new virtual
 // desktop and slides it in from the right of the screen. At the same time, the
 // old virtual desktop slides off to the left. This animation takes one second,
 // and the time is not customizable without elevated privileges or a
 // self-modifying binary
 // (https://code.google.com/p/chromium/issues/detail?id=414527). During that
 // second, no user interaction is possible.
 //
 // The default implementation of the AppKit transition smoothly animates a
-// window from its original size to the full size of the screen. At the
+// window from its original size to the expected size. At the
 // beginning of the animation, it takes a snapshot of the window's current
 // state. Then it resizes the window, calls drawRect: (theorized, not tested),
 // and takes a snapshot of the window's final state. The animation is a simple
 // crossfade between the two snapshots. This has a flaw. Frequently, the
 // renderer has not yet drawn content for the resized window by the time
 // drawRect: is called. As a result, the animation is effectively a no-op. When
 // the animation is finished, the new web content flashes in.
 //
-// The window's delegate can override two methods to customize the transition.
+// The window's delegate can override four methods to customize the transition.
 //  -customWindowsToEnterFullScreenForWindow:
 //    The return of this method is an array of NSWindows. Each window that is
 //    returned will be added to the new virtual desktop after the animation is
 //    finished, but will not be a part of the animation itself.
 //  -window:startCustomAnimationToEnterFullScreenWithDuration:
 //    In this method, the window's delegate adds animations to the windows
 //    returned in the above method.
+//  -customWindowsToExitFullScreenForWindow:
+//    This method is similar to customWindowsToEnterFullScreenForWindow, but
+//    will be used for exiting full screen
+//  -window:startCustomAnimationToExitFullScreenWithDuration:
+//    In this method, the window's delegate adds animations to the windows
+//    returned in the above method.
 //
 // The goal of this class is to mimic the default animation, but instead of
 // taking a snapshot of the final web content, it uses the live web content
 // during the animation.
 //
 // See https://code.google.com/p/chromium/issues/detail?id=414527#c22 and its
 // preceding comments for a more detailed description of the implementation,
 // and the reasoning behind the decisions made.
 //
-// Recommended usage:
-//  (Override method on NSWindow's delegate)
+// Recommended usage for entering full screen:
+//  (Override method on NSWindow's delegate):
 //  - (NSArray*)customWindowsToEnterFullScreenForWindow:(NSWindow*)window {
 //    self.transition = [[[BrowserWindowEnterFullscreenTransition alloc]
-//        initWithWindow:window] autorelease];
-//    return [self.transition customWindowsToEnterFullScreen];
+//        initEnterWithWindow:window] autorelease];
+//    return [self.transition customWindowsForFullScreen];
 //  }
 //
 //  (Override method on NSWindow's delegate)
 //  - (void)window:(NSWindow*)window
 //  startCustomAnimationToEnterFullScreenWithDuration:(NSTimeInterval)duration {
 //    [self.transition
-//        startCustomAnimationToEnterFullScreenWithDuration:duration];
+//        startCustomFullScreenAnimationWithDuration:duration];

[Andre, 2015/08/13 23:03:18]

nit: I think this will fit in a single line without wrapping.

[spqchan1, 2015/08/14 01:08:26]

Done.

 //  }
 //
 //  (Override method on NSWindow's delegate)
 //  - (void)windowDidEnterFullScreen:(NSNotification*)notification {
 //    self.transition = nil;
 //  }
 //
 //  (Override method on NSWindow)
 //  - (NSRect)constrainFrameRect:(NSRect)frame toScreen:(NSScreen*)screen {
 //    if (self.transition && ![self.transition shouldWindowBeConstrained])
 //      return frame;
 //    return [super constrainFrameRect:frame toScreen:screen];
 //  }
+//
+//  For exiting fullscreen, you should do the same as above, but you must
+//  override following methods instead.
+//      - customWindowsToExitFullScreenForWindow:,
+//      - startCustomAnimationToEnterFullScreenWithDuration:
+//      - windowDidExitFullScreen:

[Andre, 2015/08/13 23:03:19]

nit: no spaces after '-'

[spqchan1, 2015/08/14 01:08:26]

Done.

+//  In addition, you should use initExitWithWindow:frame: instead of
+//  initEnterWithWindow:. For the frame parameter, you should pass the expected
+//  frame of the window at the end of the transition. If you want the window to
+//  resize and move to the frame it had before entering fullscreen, you will be
+//  responsible for saving the value of the frame and passing it to the
+//  parameter.
 
-@interface BrowserWindowEnterFullscreenTransition : NSObject
+@interface BrowserWindowFullscreenTransition : NSObject
 
-// Designated initializer. |window| is the NSWindow that is going to be moved
+// Designated initializers. |window| is the NSWindow that is going to be moved
 // into a fullscreen Space (virtual desktop), and resized to have the same size
 // as the screen. |window|'s root view must be layer backed.
-- (instancetype)initWithWindow:(NSWindow*)window;
+// initEnterWithWindow will create a BrowserWindowFullscreenTransition that
+// enters fullscreen. initExitWithWindow will create one that exits fullscreen,
+// using |frame| as the frame that |window| is going to transition into.
+- (instancetype)initEnterWithWindow:(FramedBrowserWindow*)window;
+- (instancetype)initExitWithWindow:(FramedBrowserWindow*)window
+                             frame:(NSRect)frame;
 
-// Returns the windows to be used in the custom transition.
-//   - Takes a snapshot of the current window.
-//   - Makes a new snapshot window which shows the snapshot in the same
-//   location as the current window.
-//   - Adds the style mask NSFullScreenWindowMask to the current window.
-//   - Makes the current window transparent, and resizes the current window to
-//   be the same size as the screen.
-- (NSArray*)customWindowsToEnterFullScreen;
+// Returns the windows to be used in the custom fullscreen transition.
+- (NSArray*)customWindowsForFullScreenTransition;
 
-// Begins the animations used for the custom fullscreen transition.
-//   - Animates the snapshot to the full size of the screen while fading it out.
-//   - Animates the current window from it's original location to its final
-//   location, while fading it in.
+// This method begins animation for exit or enter fullscreen transition.
+// In this method, the following happens:
+//   - Animates the snapshot to the expected final size of the window while
+//   fading it out.
+//   - Animates the current window from its original to final location and size
+//   while fading it in.
+// If the transition is for exiting fullscreen, we would shrink the content view
+// to the expected final size so that we can to avoid clipping from the
+// window.
+

[Andre, 2015/08/13 23:03:19]

nit: this blank line makes the above comment not part of the below method.
Add // to this line if you want a blank line.

[spqchan1, 2015/08/14 01:08:26]

Done.

 // Note: The two animations are added to different layers in different windows.
 // There is no explicit logic to keep the two animations in sync. If this
 // proves to be a problem, the relevant layers should attempt to sync up their
 // time offsets with CACurrentMediaTime().
-- (void)startCustomAnimationToEnterFullScreenWithDuration:
-    (NSTimeInterval)duration;
+- (void)startCustomFullScreenAnimationWithDuration:(NSTimeInterval)duration;
 
 // When this method returns true, the NSWindow method
 // -constrainFrameRect:toScreen: must return the frame rect without
 // constraining it. The owner of the instance of this class is responsible for
 // hooking up this logic.
 - (BOOL)shouldWindowBeUnconstrained;
 
+// Returns the size of the window we expect the BrowserWindowLayout to have.
+// During the exit fullscreen transition, the content size shrinks while the
+// window frame stays the same. When that happens, we want to set the
+// BrowserWindowLayout's window parameter to the content size instead of the
+// actual window's size.
+- (NSSize)getDesiredWindowLayoutSize;

[Andre, 2015/08/13 23:03:19]

We don't usually use the 'get' prefix for Objective-C getter methods.

[spqchan1, 2015/08/14 01:08:26]

Done.

+
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_FULLSCREEN_TRANSITION_H_